On 03/22/2016 11:07 PM, David Miller wrote:
On 03/22/2016 10:27 PM, Sergei Shtylyov wrote:
The driver calls gpiod_set_value() with GPIOD_OUT_* instead of 0 and
1, as
a result the PHY isn't really put back into reset state in
macb_remove().
Moreover, the driver assumes that something else has set the GPIO
direction
to output, so if it has not, the PHY wouldn't be taken out of reset in
s/wouldn't/may not/, sorry. Do I need to resend?
No need, I fixed it up by hand.
Applied, thanks.
Oops, forgot another tag:
Fixes: 270c499f0993 ("net/macb: Update device tree binding for resetting PHY
using GPIO")
Too late probably... :-(
MBR, Sergei
