Re: [PATCH] macb: fix PHY reset

[Sergei Shtylyov]

On 03/22/2016 11:07 PM, David Miller wrote:

The driver calls gpiod_set_value() with GPIOD_OUT_* instead of 0 and
1, as
a result the PHY isn't really put back into reset state in
macb_remove().
Moreover, the driver assumes that something else has set the GPIO
direction
to output, so if it has not, the PHY wouldn't be taken out of reset in

    s/wouldn't/may not/, sorry. Do I need to resend?

No need, I fixed it up by hand.

Applied, thanks.

   Thank you! gpio_request() or smth of that sort wouldn't hurt too (the pin 
won't be switched to the GPIO mode on the pin function controller that I have 
here...
   Anyway, this code is doomed if my phylib reset GPIO patch (to be posted 
yet) is accepted ...

MBR, Sergei