Hi Peppe,

Just one remark below

> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c 
> b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
> index 6a52fa1..d2322e9 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c

[snip]

> +static bool stmmac_dt_phy(struct plat_stmmacenet_data *plat,
> +                         struct device_node *np, struct device *dev)
> +{
> +       bool ret = true;
> +
> +       /* If phy-handle property is passed from DT, use it as the PHY */
> +       plat->phy_node = of_parse_phandle(np, "phy-handle", 0);
> +       if (plat->phy_node)
> +               dev_dbg(dev, "Found phy-handle subnode\n");
> +
> +       /* If phy-handle is not specified, check if we have a fixed-phy */
> +       if (!plat->phy_node && of_phy_is_fixed_link(np)) {
> +               if ((of_phy_register_fixed_link(np) < 0))
> +                       return -ENODEV;
> +
stmmac_dt_phy() function should return a Boolean


Best Regards.

Gabriel

Reply via email to