Herbert Xu wrote:
David Daney <[EMAIL PROTECTED]> wrote:
+ /* If link local address (169.254.0.0/16) we must broadcast
+ * the ARP packet. See RFC 3927 section 2.5 for details.
+ */
+ lla = (dest_ip & htonl(0xFFFF0000UL)) == htonl(0xA9FE0000UL);
Is this really meant to be dest_ip as opposed to src_ip?
The variables seem to be misnamed, the patch does not try to rectify
that issue.
What do you mean? src_ip is our IP and dest_ip is the target's IP.
Ok, so I am a little confused. Perhaps less so now.
In any event, yes we should be testing the dest_ip. If the ARP packet
is destined for the link local network, it should be broadcast.
David Daney
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
