On Wed, 22 February 2006 18:44:33 +0100, Michael Buesch wrote:
> On Wednesday 22 February 2006 09:26, you wrote:
> > Fairly trivial. The extra conditional should get optimized away with
> > current code. But it also allows to walk through network drivers and
> > get rid of the permanent
> > if (skb)
> > kfree(skb);
> > conditionals.
>
> I am all for this change, but I am wondering how this is
> possible to get optimized away... The compiler can't know
> if a skb variable is NULL or not, at runtime.
if (skb) {
/* the compiler can know that skb is non-NULL now */
kfree_skb(skb);
}
I must admit that I haven't tested whether gcc will optimize it away,
though.
Jörn
--
It is better to die of hunger having lived without grief and fear,
than to live with a troubled spirit amid abundance.
-- Epictetus
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
