J?rn Engel <[EMAIL PROTECTED]> wrote: > Fairly trivial. The extra conditional should get optimized away with > current code. But it also allows to walk through network drivers and > get rid of the permanent > if (skb) > kfree(skb); > conditionals.
This is bad because it hides bugs. In places where skb should never be NULL you've just made it silently ignore what should be a fatal error. -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
