Ok, it is really attached now ;-> cheers, jamal
On Sun, 2006-15-01 at 16:37 -0500, jamal wrote: > Stephen, > > This is against the latest iproute2 > > cheers, > jamal > > - > To unsubscribe from this list: send the line "unsubscribe netdev" in > the body of a message to [EMAIL PROTECTED] > More majordomo info at http://vger.kernel.org/majordomo-info.html >
the prio qdisc assumes a default priomap which is suited for 3 bands when you configure > 3 bands but not specify the priomap. This forces the user to specify the priomap when bands >3 Signed-off-by: Jamal Hadi Salim <[EMAIL PROTECTED]> --- tc/q_prio.c | 10 +++++----- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/tc/q_prio.c b/tc/q_prio.c index d696e1b..3be7000 100644 --- a/tc/q_prio.c +++ b/tc/q_prio.c @@ -84,12 +84,12 @@ static int prio_parse_opt(struct qdisc_u argc--; argv++; } -/* - if (pmap_mode) { - for (; idx < TC_PRIO_MAX; idx++) - opt.priomap[idx] = opt.priomap[TC_PRIO_BESTEFFORT]; + if (opt.bands != 3 && !pmap_mode) { + fprintf(stderr, "You must specify the priomap\n", *argv); + explain(); + return -1; } -*/ + addattr_l(n, 1024, TCA_OPTIONS, &opt, sizeof(opt)); return 0; }