jamal wrote:
On Mon, 2006-16-01 at 05:56 +0100, Patrick McHardy wrote:
This is a dead horse since I ACKed the patch, but that patch
is _wrong_ without the user space fix.
What's wrong with this:
tc qdisc add dev dummy0 root handle 1: prio bands 5
for i in $(seq 1 5); do
tc filter add dev dummy0 parent 1: handle $i fw classid 1:$i
done
Should tc configure 3 bands in the priomap if i specify 2 bands?
It does.
If it does the kernel will reject it.
;-> so in your opinion was it fine for tc to send it anyways or does tc
need fixing? ;->
It shouldn't use the default mapping if its known to be invalid.
To put it simple: I don't care about priomap. It is one of two
mechanisms to classify in the prio qdisc and it makes no sense
to force users to use it.
Then why bother sending a priomap at all? Lets just use the one in the
kernel
For the default that would be fine, but it doesn't have a seperate
attribute.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
