On Tue, 2006-10-01 at 07:18 -0800, Amnon Aaronsohn wrote: [..] > Anyway, even when all the bands appear in the priomap, > it makes more sense to go over each band only once as > the patch does, instead of multiple times as the > current implementation. >
So it is an optimization - not a bug then, correct? That is probably a better explanation although your text description in the patch is quiet confusing. There is no bug AFAICS. Note: that routine is invoked by both add (which first goes through _init) as well as change/replace (which call it directly). It is possible that the number of bands to go up or even down after the initial creation. Can you test the scenario where: -> you create the qdisc with the default three band -> do a change to go upto 8 bands with a new priomap -> do another change/replace to go down to say 4 bands with a new priomap -> A replace that keeps the same bands but mucks around the priomap This is probably what your code was doing already although i didnt understand why youd want to keep changing these parameters. In between do traffic with whatever code you have. cheers, jamal - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
