* Patrick McHardy <[EMAIL PROTECTED]> 2006-01-12 06:25 > David S. Miller wrote: > >From: jamal <[EMAIL PROTECTED]> > >Date: Tue, 10 Jan 2006 23:02:45 -0500 > > > > > >>So it is an optimization - not a bug then, correct? > > > > > >It is only an optimization in as much as it avoids duplicate > >work during initialization. > > > >Like you I don't see how this patch fixes anything. > > > >No matter what you set skb->priority to, that gets translated > >by prio2band[] which should only point to actually initialized > >queues. > > In the last case in prio_classify (band < q->bands) the band > is returned directly. This could come from attached filters > or from skb->priority. Its still not a fix since all bands > have at least noop-qdiscs attached to them, just a semantic > change which IMO makes sense.
I agree with Patrick, this patch makes perfect sense to although the description is a bit misleading. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html