Jamal Hadi Salim wrote:
We've had this discussion before, Patrick;->
Heres one i was able to find:
http://marc.theaimsgroup.com/?t=110611159500001&r=1&w=2
So NACK this spefic patch please.
That discussion had nothing to do with this patch, you actually
already agreed to doing this. Passing double skb pointers is broken:
int tcf_action_exec(struct sk_buff *skb, struct tc_action *act,
struct tcf_result *res)
{
...
ret = a->ops->act(&skb, a, res);
The caller later continues to use the skb passed to tcf_action_exec
and will crash if it was replaced.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
