On Sun, 2006-08-01 at 19:32 +0100, Patrick McHardy wrote: > Jamal Hadi Salim wrote: > >It seems to be a big > > change at glance and normally i would like to run some serious tests > > on something like this (this one you can actually test with a series of > > mirred, pedit and gact while tcpdump is running - doesnt matter if > > ingress or egress and then watch the hex dump of modified packets) > > Its not a big change, just look at the patch, all it does is change > the argument to a single skb pointer instead of a double skb pointer > to a local variable. Every action did "struct sk_buff *skb = *pskb" > right at the beginning of their action function anyway. >
[..] > This is all fine and doesn't need double skb pointers. Double pointers > are needed if an action wants to replace the skb in the callers context. > It can replace it in tcf_action_exec's context, but the caller of > tcf_action_exec will still see and use the old skb because > tcf_action_exec only gets a copy of its pointer. So using double > skb pointers is confusing at least, because it looks like actions could > replace skbs in the callers context, which they can't. > I hope that clears it up. ;-> Yes it does and now i remember we discussed it ;-> I am gonna take a nap i think;-> cheers, jamal - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
