On Mon, 2005-25-07 at 22:09 +0200, Thomas Graf wrote: > * David S. Miller <[EMAIL PROTECTED]> 2005-07-25 12:09 > > Ok, so can we agree on the following patch? ing_filter() should > > never see a NULL ->input_dev, and we could add a BUG() check > > there for that invariant if you want. > > This looks good to me, a input_dev==NULL means the packets > origin is local.
Not necessarily true. But shouldnt matter in this case - that code should just set it. > The code block which uses input_dev is dead, TC_NCLS is never > set as of now. Jamal might have use for it though? Generally, > tcf_action_exec() may be called on both ingress and egress. I mentioned the meta action already; the dummy device replacement for IMQ also uses it. The ematch shouldnt really care about interpretting it - it should just classify on it. cheers, jamal - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
