On Mon, 30 Mar 2026 09:20:11 GMT, Alan Bateman <[email protected]> wrote:
>> The class doesn't say it "*references* module entries", it says (cut & paste >> from the docs) it "*Represents* the module entries...". It the >> representation of the data from which the nodes you see inside package >> subdirectories are created (which is handled differently to all other nodes). >> >> I tweaked to comments a bit, but since the class renaming is significant, >> I'd like to see if we can make sure we're happy with any new name before I >> do it. >> >> `readNameOffsets` uses the encapsulated constants. If it moved then the >> constants must either be made public or duplicated. > >> it "Represents the module entries...". > > Do you mind looking for a different name? It is very confusing to have it be > named ModuleReference when we already have a ModuleReference that is a > reference a module's content. > > readNameOffsets is surprising to see here because it's a static method that > doesn't have a ModuleReference its method signature. Changed name to ModuleLink (as discussed offline). ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/29414#discussion_r3064986897
