On Sun, 29 Mar 2026 10:24:34 GMT, Alan Bateman <[email protected]> wrote:
>> David Beaumont has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 12 commits: >> >> - Merge branch 'master' into jimage_preview_mode >> - rename jimage_exists to jimage_is_open >> - Feedback tweaks >> - Feedback tweaks >> - More feedback tweaks >> - Updated copyright >> - Feedback changes >> - Merge branch 'master' into jimage_preview_mode >> - Merge branch 'master' into jimage_preview_mode >> - undo exploded image changes for now >> - ... and 2 more: https://git.openjdk.org/jdk/compare/7695b1f9...0e802079 > > src/java.base/share/classes/jdk/internal/jimage/ImageReader.java line 275: > >> 273: // preview-only nodes. This is used to add preview-only content >> to >> 274: // directories as they are completed. >> 275: private final Map<String, Directory> previewDirectoriesToMerge; > > I think it would be better if we could use the stick with the term "overlay" > when speaking of the resources in /META-INF/preview as it is confusing to see > "merge" in some of the method names and comments. > > Also would it be possible to explain what you mean by "relativized mapping" > here? This is a "merging" operation though. And overlay would be a view of two bits of data to make them look the same, but this is data which is merged with other data to form a single result that's not a view of several things. I'm using "relativized" in the same sense as `Path.relativize()` but I'll explain what it's relative to. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/29414#discussion_r3008381582
