On Wed, 8 Apr 2026 09:20:31 GMT, Alan Bateman <[email protected]> wrote:

>> Daniel Fuchs has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   EOF not expected
>
> test/jdk/java/net/Socket/ConnectionReset.java line 95:
> 
>> 93:                     System.err.println("read => 1 byte");
>> 94:                     // we should get an IOException before reading
>> 95:                     // the last byte
> 
> This comment is confusing too, it should not read bytes after IOException is 
> thrown.

Yes - but it is OK to read one byte as long as it is not the last one, 
otherwise we would not assert that remaining > 0 and continue reading. 
Obviously if we reach here the exception has not been thrown by in.read() yet. 
Let me see if I can improve that comment...

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/30564#discussion_r3050636436

Reply via email to