On Thu, 26 Mar 2026 12:30:33 GMT, serhiysachkov <[email protected]> wrote:
>> Update testng and junit tests to use diagnoseConfigurationIssue() method and
>> post processing
>
> serhiysachkov has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now contains six commits:
>
> - Merge branch 'master' into JDK-8380990
> - 8380990: fix merge junit conversion issue
> - 8380990: fix merge space issue
> - 8380990: copyright format issue fix
> - Merge branch 'master' into JDK-8380990
> - 8380990: Update testng and junit tests to use diagnoseConfigurationIssue()
> method and post processing
Hi @serhiysachkov did you not merge the master branch after pushing changes to
`IPSupport`?
test/jdk/java/nio/channels/DatagramChannel/AfterDisconnect.java line 100:
> 98: public void execute() throws IOException {
> 99: Optional<String> configurationIssue =
> diagnoseConfigurationIssue();
> 100: Assumptions.assumeTrue(configurationIssue.isEmpty(),
> configurationIssue.orElse(""));
Suggestion:
diagnoseConfigurationIssue().ifPresent(Assumptions::abort);
test/jdk/java/nio/channels/DatagramChannel/SendReceiveMaxSize.java line 113:
> 111: public static void setUp() {
> 112: Optional<String> configurationIssue =
> diagnoseConfigurationIssue();
> 113: Assumptions.assumeTrue(configurationIssue.isEmpty(),
> configurationIssue.orElse(""));
Suggestion:
diagnoseConfigurationIssue().ifPresent(Assumptions::abort);
test/jdk/java/nio/channels/etc/LocalSocketAddressType.java line 63:
> 61: IPSupport.printPlatformSupport(out);
> 62: Optional<String> configurationIssue =
> diagnoseConfigurationIssue();
> 63: Assumptions.assumeTrue(configurationIssue.isEmpty(),
> configurationIssue.orElse(""));
Suggestion:
diagnoseConfigurationIssue().ifPresent(Assumptions::abort);
test/jdk/java/nio/channels/etc/OpenAndConnect.java line 94:
> 92: IPSupport.printPlatformSupport(out);
> 93: Optional<String> configurationIssue =
> diagnoseConfigurationIssue();
> 94: Assumptions.assumeTrue(configurationIssue.isEmpty(),
> configurationIssue.orElse(""));
Suggestion:
diagnoseConfigurationIssue().ifPresent(Assumptions::abort);
test/jdk/java/nio/channels/etc/ProtocolFamilies.java line 82:
> 80: IPSupport.printPlatformSupport(out);
> 81: Optional<String> configurationIssue =
> diagnoseConfigurationIssue();
> 82: Assumptions.assumeTrue(configurationIssue.isEmpty(),
> configurationIssue.orElse(""));
Suggestion:
diagnoseConfigurationIssue().ifPresent(Assumptions::abort);
test/lib/jdk/test/lib/net/IPSupport.java line 1:
> 1: /*
Why do we still have this change? Didn't you merge the master branch?
-------------
PR Review: https://git.openjdk.org/jdk/pull/30446#pullrequestreview-4054799264
PR Review Comment: https://git.openjdk.org/jdk/pull/30446#discussion_r3031965369
PR Review Comment: https://git.openjdk.org/jdk/pull/30446#discussion_r3031968688
PR Review Comment: https://git.openjdk.org/jdk/pull/30446#discussion_r3031970685
PR Review Comment: https://git.openjdk.org/jdk/pull/30446#discussion_r3031972781
PR Review Comment: https://git.openjdk.org/jdk/pull/30446#discussion_r3031973871
PR Review Comment: https://git.openjdk.org/jdk/pull/30446#discussion_r3031981137
