On Thu, 26 Mar 2026 11:35:08 GMT, Daniel Fuchs <[email protected]> wrote:
>> serhiysachkov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8380990: fix merge junit conversion issue
>
> test/jdk/java/lang/ProcessBuilder/ReaderWriterTest.java line 182:
>
>> 180: System.out.println("Charset: " + cs);
>> 181: } catch (UnsupportedCharsetException use) {
>> 182: throw new TestAbortedException("Charset not supported: " +
>> encoding);
>
> @sormuras will be able to confirm, but I believe the blessed way of doing
> that with JUnit would be to call something like:
>
> Assumptions.assumeTrue(false, "Charset not supported: " + encoding);
Assumptions.assumeTrue throws TestAbortedException exception if condition not
met, wasn't comfortable with passing non conditional boolean to Assumption, but
if this is recommended way, I can update it.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/30446#discussion_r2994275749
