On Fri, 20 Mar 2026 13:01:49 GMT, Jaikiran Pai <[email protected]> wrote:
>> Can I please get a review of this test-only change which proposes to update >> the `test/jdk/java/net/DatagramPacket/ReuseBuf.java` test to use a loopback >> address? >> >> As noted in https://bugs.openjdk.org/browse/JDK-8380534, this test uses >> non-loopback address to send and receive datagram packets, and has been >> failing on some of the macos hosts that we run this test on. Given what the >> test was introduced for in https://bugs.openjdk.org/browse/JDK-4424096, it >> doesn't necessarily require the use of a non-loopback address. >> >> The commit in this PR updates the test to use loopback address. Few other >> clean ups have been done too, to properly close the resources. >> >> The updated test now passes on all platforms (I launched multiple test runs). > > Jaikiran Pai has updated the pull request incrementally with two additional > commits since the last revision: > > - await for the server thread to complete > - Daniel's review - fail the test if there's an exception on the server side LGTM ------------- Marked as reviewed by dfuchs (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/30335#pullrequestreview-3981720808
