> Can I please get a review of this test-only change which proposes to update > the `test/jdk/java/net/DatagramPacket/ReuseBuf.java` test to use a loopback > address? > > As noted in https://bugs.openjdk.org/browse/JDK-8380534, this test uses > non-loopback address to send and receive datagram packets, and has been > failing on some of the macos hosts that we run this test on. Given what the > test was introduced for in https://bugs.openjdk.org/browse/JDK-4424096, it > doesn't necessarily require the use of a non-loopback address. > > The commit in this PR updates the test to use loopback address. Few other > clean ups have been done too, to properly close the resources. > > The updated test now passes on all platforms (I launched multiple test runs).
Jaikiran Pai has updated the pull request incrementally with two additional commits since the last revision: - await for the server thread to complete - Daniel's review - fail the test if there's an exception on the server side ------------- Changes: - all: https://git.openjdk.org/jdk/pull/30335/files - new: https://git.openjdk.org/jdk/pull/30335/files/997a53b5..7208af80 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=30335&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=30335&range=00-01 Stats: 22 lines in 1 file changed: 16 ins; 2 del; 4 mod Patch: https://git.openjdk.org/jdk/pull/30335.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/30335/head:pull/30335 PR: https://git.openjdk.org/jdk/pull/30335
