Hi Jason, I had a spare night last night so I was able to add this. Still if
you find the urge to dig in to the code I am sure that would help out :-).
I have had more time to think about it and I agree it should be on by default.
The comment should have said "unexpected behavior", referring to the fact that
the cvs tasks will now respect the .cvsignore files. Still I think the other
way was a bug and it should be on by default. Giving the option to shut it off
should solve any issues with compatibility.
Cheers,
Clayton
-----Original Message-----
From: Morris, Jason [mailto:[EMAIL PROTECTED]
Sent: Tue 1/18/2005 6:36 AM
To: nant-users@lists.sourceforge.net
Cc:
Subject: RE: [Nant-users] Do the <cvs-*> tasks comprehend having
.cvsignore files?
Thanks for the quick turn around! I thought that I would have to dive
into the code myself. I will wait for the next nightly and test it out.
Last nightly was on the 15th.
+1 for on by default.
My $.02 is that it is on by default without the need to specify it as an
attribute. My assumption is that .cvsignore is a common CVS file that
all CVS clients use to ignore files and I would assume that <cvs-*>
tasks would want to do the same. I only use TortoiseCVS as my CVS
client, so I am not that familiar with how the command line client,
WinCVS, or others clients work with .cvsignore.
Jason
PS What was the "odd behavior" comment about when you checked the code
into CVS?
>-----Original Message-----
>From: Clayton Harbour [mailto:[EMAIL PROTECTED]
>Sent: Tuesday, January 18, 2005 1:30 AM
>To: Morris, Jason; nant-users@lists.sourceforge.net
>Subject: RE: [Nant-users] Do the <cvs-*> tasks comprehend
>having .cvsignore files?
>
>Hi Jason, I have implemented this by adding a usecvsignore
>attribute to the cvs fileset element so:
>
> <cvs-update usesharpcvslib="false" verbose="${isVerbose}"
>failonerror="true">
> <fileset usecvsignore="true">
> <include name="**" />
> </fileset>
> <arg line="-q -x" />
> </cvs-update>
>
>I have the value turned off by default to keep it backwards
>compatible but I wanted to get some feedback/ thoughts on
>this. Should the .cvsignore files be picked up by default or
>should this be explicitly specified? Let me know, if there
>are no strong opinions I will leave as is (off).
>
>
>Cheers,
>
>Clayton
>
>> -----Original Message-----
>> From: Morris, Jason [mailto:[EMAIL PROTECTED]
>> Sent: January 17, 2005 7:32 PM
>> To: nant-users@lists.sourceforge.net
>> Subject: [Nant-users] Do the <cvs-*> tasks comprehend having
>> .cvsignore files?
>>
>>
>> Do the cvs tasks inside of nant read the .cvsignore files? I was
>> hoping that they do, but my testing reveals that they don't. I hope
>> that I am not missing something.
>>
>> I have tried
>>
>> <cvs-update usesharpcvslib="false"
>> verbose="${isVerbose}"
>> failonerror="true">
>> <fileset>
>> <include name="**" />
>> </fileset>
>> <arg line="-q -x" />
>> </cvs-update>
>>
>> But it prompts for files that I have listed in my .cvsignore files.
>>
>> I am not sure if .cvsignore is support by all CVS clients,
>but I think
>> that it would be a great addition if the CVS tasks would recognize
>> this file.
>>
>> Jason
>>
>>
>> -------------------------------------------------------
>> The SF.Net email is sponsored by: Beat the post-holiday blues Get a
>> FREE limited edition SourceForge.net t-shirt from ThinkGeek.
>It's fun
>> and FREE -- well, almost....http://www.thinkgeek.com/sfshirt
>> _______________________________________________
>> Nant-users mailing list
>> Nant-users@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/nant-users
>>
>
-------------------------------------------------------
The SF.Net email is sponsored by: Beat the post-holiday blues
Get a FREE limited edition SourceForge.net t-shirt from ThinkGeek.
It's fun and FREE -- well, almost....http://www.thinkgeek.com/sfshirt
_______________________________________________
Nant-users mailing list
Nant-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nant-users
