You mean, like this  ( produced w/ csdiff )
/jean

.\NAnt.Core\Tasks\IfTask.cs


84c84
<         protected FileSet _compareFiles = null;
==========
>         protected FileSet _compareFiles = new FileSet();
99c99
<             set {
==========
>             set { _compareFiles.Includes.Add(value); }
100,105d99
<                 //I'm really not sure this is the best way to do this!
<                 FileSet fs = new FileSet();
<                 fs.Parent = this;
<                 fs.Project = this.Project;
<                 fs.Includes.Add(value);
<                 CompareFiles = fs;
107d100
<         }
113c106
<             set {_compareFiles = value;}
==========
>            get { return _compareFiles; }




> From: Scott Hernandez [mailto:[EMAIL PROTECTED] 
... 
> It sounds like a bug. Please provide a cvs diff (with -u) for 
> any changes you want to the dev list.
...
> >From: "Jean Rajotte" <[EMAIL PROTECTED]>
> >
> > 1) test that fails:
> >
> >     <property name="doGen" value="false" />
> >     <if uptodateFile="c:\bob.txt"  >
> >       <comparefiles>
> >         <includes name="d:\*.txt" />
> >       </comparefiles>
> >       <property name="doGen" value="true" />
> >     </if>
> >
> > I.e: given a c:\bob.txt file that's older than d:\*.txt, 
> goGen should 
> > become true but doesn't.  Actually, nant crashes.
> >
> > 2) the fix:
> >
> > 2.a) Do init the fileset locally
...
> > 2.b) just add to it in the singular
...
> > 2.c) provide a getter, not a setter
...
> >
> > 3) mild gripe about names:
> > 3.a) It seems that if is the only task that has mixed case param 
> > names. Everywhere else, it's all lower-case.
> >
> > <if uptodateFile="" compareFile="" >
> > Could/should be
> > <if uptodatefile="" comparefile="" >
> >
> > 3.b) <comparefiles> is the only fileset that's not called 
> <fileset>, 
> > that I can see.  Nice touch, but it had me confused for a while.



-------------------------------------------------------
This SF.net email is sponsored by: ValueWeb: 
Dedicated Hosting for just $79/mo with 500 GB of bandwidth! 
No other company gives more support or power for your dedicated server
http://click.atdmt.com/AFF/go/sdnxxaff00300020aff/direct/01/
_______________________________________________
Nant-users mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/nant-users

Reply via email to