Sorry for my earlier post re: using filesets in <if>.  The expected
syntax isn't <fileset>, it's <comparefiles>.  Still, when I use
<comparefiles>, there's still problems.  I found that it's because the
fileset in comparefiles isn't set up properly.  Basically, there's a
bug.  I've fixed it in my version of the source.  I don't know where/how
to officially submit it to the responsible parties, so I'll just do it
here.

1) test that fails:
    
    <property name="doGen" value="false" />
    <if uptodateFile="c:\bob.txt"  >
      <comparefiles>
        <includes name="d:\*.txt" />
      </comparefiles>
      <property name="doGen" value="true" />
    </if>

I.e: given a c:\bob.txt file that's older than d:\*.txt, goGen should
become true but doesn't.  Actually, nant crashes.

2) the fix:

2.a) Do init the fileset locally
        protected FileSet _compareFiles = new FileSet();

2.b) just add to it in the singular
        [TaskAttribute("compareFile")]
        public string CompareFile {
            set {
                _compareFiles.Includes.Add(value);
            }
        }
2.c) provide a getter, not a setter
        [FileSet("comparefiles")]
        public FileSet CompareFiles {
           get { return _compareFiles; }
        }

3) mild gripe about names:
3.a) It seems that if is the only task that has mixed case param names.
Everywhere else, it's all lower-case.

<if uptodateFile="" compareFile="" >
Could/should be
<if uptodatefile="" comparefile="" >

3.b) <comparefiles> is the only fileset that's not called <fileset>,
that I can see.  Nice touch, but it had me confused for a while.

HTH

/jean

____________
Jean Rajotte
+1 416-574-1767



-------------------------------------------------------
This SF.net email is sponsored by: ValueWeb: 
Dedicated Hosting for just $79/mo with 500 GB of bandwidth! 
No other company gives more support or power for your dedicated server
http://click.atdmt.com/AFF/go/sdnxxaff00300020aff/direct/01/
_______________________________________________
Nant-users mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/nant-users

Reply via email to