In article <[EMAIL PROTECTED]>, Gervase Markham wrote:
> Daniel Wang wrote:
> 
>> +    // Don't nag for stable 1.0 & 1.4 releases
>> +    if (ua.match(/rv:1\.(4|0)(\.\d)?)/)) {
>> +      return;
>> +    }
> 
> How does this only catch stable 1.4 users, and not catch people using 
> other 1.4-era builds?

It won't catch 1.4alpha/beta users.  It will catch users of 1.4-branch
nightlies (including the 1.4 release candidates), but as previously
discussed , there's no way of distinguishing release builds from nightlies
with the same revision (unless someone wants to produce a list of the
build ids from the builds across the 60 or so languages and platforms
listed at http://www.mozilla.org/releases/#1.4 and keep it updated)

> (Stable 1.0 users won't see that page anyway, so I'm not worried about
> them.)

Given that people with 1.0(.x), and 1.4.1, 1.4.2, etc aren't likely to
visit that page, it could be simplified to:
if (ua.match(/rv:1\.4/)) {

-- 
Michael

Reply via email to