On 2016-06-10 1:27 PM, Ben Bucksch wrote: > Is MozReview the same as ReviewBoard https://reviewboard.mozilla.org/ ? Yes, although MozReview refers to the whole system, which includes the review repo, Autoland, BMO integration, etc. Review Board is a third-party application that we've been customizing for our needs (via extensions).
> I was missing a trivial, obvious, one-click way to get a normal unifed > diff (diff -U3) as plaintext in a browser window. I am used to read > them, save them to disk, apply them. Yeah, there's an option to download, but we know people want to open it in a window too. We have bug 1252946 filed for this. > Also, reviewboard was mostly about discussion. When I go to > https://reviewboard.mozilla.org/r/3965/, I see a list of "commits", > but I don't see where the actual code change is. I don't care about > the commits the developer made, this is where reviewboard completely > lost me. I want to see the entire code diff immediately, in the most > recent version, without having to click or expand anything. (And it > should load quickly.) Then I want to click on a code line, and make a > comment about that code change. Then the developer should be able to > respond to my comment etc. (building several discussion threads), but > the primary thing is still the code, not the comments. There are two things here: 1. Yes, I don't particularly like that the default view is the conversation either. We've worked around this a bit by having links to the diff in BMO. These views are pretty much baked into Review Board, but I'm sure there's more we can do to improve the situation. 2. "I don't care about the commits the developer made": MozReview is actually based around the philosophy of microcommits, which encourages the splitting up of work into small commits that will land as they are (i.e. not fix-at-the-end-type commits that are later squashed together). Among other benefits, it makes reviewing code easier (less to think about at once). So the commits table is rather important from that perspective (although I agree the UI around it is not ideal, which is one of the things we'll be talking about next week). > In another project, we're using Phabricator, and I like it. It gets it > right. The code diff is the primary object, comments are added with 2 > clicks, and the comments stay even when I upload a new version of the > patch. (Lines may be off a bit after a patch update, but that's > usually easy to see. Better than not seeing the comments, or having to > make a lot of clicks.) If I want to see more context code context, the > whole file is just one click away. Phabricator is indeed nice. We've been stealing some ideas from them, and that'll continue. :) Mark _______________________________________________ mobile-firefox-dev mailing list mobile-firefox-dev@mozilla.org https://mail.mozilla.org/listinfo/mobile-firefox-dev
