Is MozReview the same as ReviewBoard https://reviewboard.mozilla.org/ ?
I was missing a trivial, obvious, one-click way to get a normal unifed diff (diff -U3) as plaintext in a browser window. I am used to read them, save them to disk, apply them.
Also, reviewboard was mostly about discussion. When I go to https://reviewboard.mozilla.org/r/3965/, I see a list of "commits", but I don't see where the actual code change is. I don't care about the commits the developer made, this is where reviewboard completely lost me. I want to see the entire code diff immediately, in the most recent version, without having to click or expand anything. (And it should load quickly.) Then I want to click on a code line, and make a comment about that code change. Then the developer should be able to respond to my comment etc. (building several discussion threads), but the primary thing is still the code, not the comments.
In another project, we're using Phabricator, and I like it. It gets it right. The code diff is the primary object, comments are added with 2 clicks, and the comments stay even when I upload a new version of the patch. (Lines may be off a bit after a patch update, but that's usually easy to see. Better than not seeing the comments, or having to make a lot of clicks.) If I want to see more context code context, the whole file is just one click away.
Ben _______________________________________________ mobile-firefox-dev mailing list mobile-firefox-dev@mozilla.org https://mail.mozilla.org/listinfo/mobile-firefox-dev
