On Mon, May 9, 2016 at 1:26 PM, Sylvestre Ledru <sylves...@mozilla.com> wrote:
> Hello, > > Le 09/05/2016 à 10:15, Margaret Leibovic a écrit : > >> Hi friends, >> >> Can anyone help me understand the difference between MOZ_APP_VERSION and >> MOZ_APP_VERSION_DISPLAY? >> >> I see that in our AndroidManifest, we use MOZ_APP_VERSION to set our >> Android version name [1]. However, this means that for beta, we display the >> number version, without the "b" bit, e.g. "47.0". Looking at about:firefox >> [2], for example, I see that we use the MOZ_APP_VERSION_NAME property to >> display a number that includes the beta version, e.g. "47.0b2". It actually >> seems like beta is the only channel where version.txt [3] and >> version_display.txt [4] differ. Why is that? >> >> MOZ_APP_VERSION contains only the major version. > I introduced MOZ_APP_VERSION_DISPLAY for several reasons: > * to have the number of beta installs in telemetry (buildid are more > complex to use) > * show it in about:support > * show it in the about dialog > > This is only different in beta because it is the only place where we have > different versions on the same release channel. > (nightly is XXa1, aurora YYa2, etc) > Thanks, this is insightful. So is there any reason to not update our Android version name to use MOZ_APP_VERSION_DISPLAY as well? Similar to the reasons you mentioned above, it would give us more power to distinguish between different beta versions (in my case, in our Switchboard code). Looking through our code to see where this Android versionName property is used, it does not seem like a change would affect much. I do see that there's some logic in Adjust that gets the version name [1], but they don't even show us version info in their dashboards! It's also used in our CrashHandler code [2], which seems definitely like something we'd want to be specific. The final place I see this being used is downloadable content [3], but that also seems like it could handle more specific beta versions fine. I can file a bug for this change, where we can discuss in more detail, but this seems like a big enough change to merit over-communication. Margaret [1] https://hg.mozilla.org/mozilla-central/file/1579b9e2e50f/mobile/android/thirdparty/com/adjust/sdk/DeviceInfo.java#l107 [2] https://hg.mozilla.org/mozilla-central/file/1579b9e2e50f/mobile/android/base/java/org/mozilla/gecko/CrashHandler.java#l235 [3] https://hg.mozilla.org/mozilla-central/file/1579b9e2e50f/mobile/android/base/java/org/mozilla/gecko/dlc/StudyAction.java#l67
_______________________________________________ mobile-firefox-dev mailing list mobile-firefox-dev@mozilla.org https://mail.mozilla.org/listinfo/mobile-firefox-dev
