On Mon, May 9, 2016 at 1:30 PM, Ben Bucksch <ben.buck...@beonex.com> wrote:
> You might be limited by the Google Play store and/or manifest specs. > I'm not positive, but I think Google allows only digits separated by dots, > no letters. > > For Google Chrome extensions, I'm positive that this is the rule. That's > why we (in our ext) used the same trick, and put the "real" version > somewhere in a string, and set the digits only in the manifest. > Interesting idea. Nightly and Aurora already use letters, and although we don't publish these apps, we do have test versions of these APKs uploaded to the store, so I don't think that this would be an issue. But hopefully that's not an issue if (when!) we do start shipping these in the Play Store. Thanks, Margaret > > Margaret Leibovic wrote on 09.05.2016 19:15: > >> Hi friends, >> >> Can anyone help me understand the difference between MOZ_APP_VERSION and >> MOZ_APP_VERSION_DISPLAY? >> >> I see that in our AndroidManifest, we use MOZ_APP_VERSION to set our >> Android version name [1]. However, this means that for beta, we display the >> number version, without the "b" bit, e.g. "47.0". Looking at about:firefox >> [2], for example, I see that we use the MOZ_APP_VERSION_NAME property to >> display a number that includes the beta version, e.g. "47.0b2". It actually >> seems like beta is the only channel where version.txt [3] and >> version_display.txt [4] differ. Why is that? >> >> This question is motivated by the fact that we use the Android version >> name (MOZ_APP_VERSION) for our switchboard match condition [5]. This means >> that for beta we can't match on a specific beta version, which is what I >> want to do to test a "What's New" notification (i.e. don't create a new >> notification for users every time their beta build updates). >> >> The simplest change I can see to address this situation is to update our >> Android version name to use MOZ_APP_VERSION_DISPLAY instead of >> MOZ_APP_VERSION, but I don't know what repercussions that may have. >> Alternately, I could update our switchboard logic to use the >> MOZ_APP_VERSION value, but right now there's nothing Mozilla-specific in >> the switchboard code, and it would be great to keep it that way. >> >> Thanks, >> Margaret >> >> [1] >> https://hg.mozilla.org/mozilla-central/file/043082cb7bd8/mobile/android/base/AndroidManifest.xml.in#l7 >> [2] >> https://hg.mozilla.org/mozilla-central/file/043082cb7bd8/mobile/android/chrome/content/about.xhtml#l27 >> [3] >> https://hg.mozilla.org/releases/mozilla-beta/annotate/tip/browser/config/version.txt >> [4] >> https://hg.mozilla.org/releases/mozilla-beta/annotate/tip/browser/config/version_display.txt >> [5] >> http://hg.mozilla.org/mozilla-central/file/bae525a694e2/mobile/android/thirdparty/com/keepsafe/switchboard/SwitchBoard.java#l148 >> >> >> _______________________________________________ >> mobile-firefox-dev mailing list >> mobile-firefox-dev@mozilla.org >> https://mail.mozilla.org/listinfo/mobile-firefox-dev >> > > _______________________________________________ > mobile-firefox-dev mailing list > mobile-firefox-dev@mozilla.org > https://mail.mozilla.org/listinfo/mobile-firefox-dev >
_______________________________________________ mobile-firefox-dev mailing list mobile-firefox-dev@mozilla.org https://mail.mozilla.org/listinfo/mobile-firefox-dev
