Hello! Philipp <[email protected]> wrote: > Hi > > here we go again ;-) > > For the update to debian stable a friend of me has tested table-ldap. > He reported some problems and I looked at the code and found some issues. > > First the reported problem was a reconnecting bug. This is fixed by error > on saved requests. I also added tcp keepalive to avoid disconnects. > > Then I found some out of bounds reads. They are caused by my commit which > tried to keep the length of strings. I have reverted this and do some > better ownership handling for the generated requests. > > Also I found some double free in ldap_lookup_entry(). > > There was a missing break in ldap_handle_response() > > I have also added better error messages. > > I have smoketested this changes, but not yet full tested everything. > I plan to do more tests tomorrow. Patches are attached.
Committed the changes, they made sense to me. Overall, a nice improvement :) I have to say though that this is probably, code-wise, the worst table we have at the moment. It's ofter quite convoluted, the aldap.c part scares me, and we're missing some features as well. Not your fault, the table is just what it is and you've helped in making it suck less, which I appreciate a lot. > Philipp > > Ps: would be nice to have a release for table-ldap > after I have fully tested this patches. makes sense, let me know when you prefer and we can tag 1.1 =) > Pps: It would be nice to know who uses table-ldap. I do this in my > free time and haven't had time yet to build a good testing setup. It > would be nice if someone could help me there. I keep telling you that i want to set up something to help with the development/testing. I hope I'll finally manage to do so before summer ^^" Thanks! Omar Polo
