Hi here we go again ;-)
For the update to debian stable a friend of me has tested table-ldap. He reported some problems and I looked at the code and found some issues. First the reported problem was a reconnecting bug. This is fixed by error on saved requests. I also added tcp keepalive to avoid disconnects. Then I found some out of bounds reads. They are caused by my commit which tried to keep the length of strings. I have reverted this and do some better ownership handling for the generated requests. Also I found some double free in ldap_lookup_entry(). There was a missing break in ldap_handle_response() I have also added better error messages. I have smoketested this changes, but not yet full tested everything. I plan to do more tests tomorrow. Patches are attached. Philipp Ps: would be nice to have a release for table-ldap after I have fully tested this patches. Pps: It would be nice to know who uses table-ldap. I do this in my free time and haven't had time yet to build a good testing setup. It would be nice if someone could help me there.
0001-send-error-response-on-reconnect.patch
Description: 0001-send-error-response-on-reconnect.patch
0002-enable-keepalive.patch
Description: 0002-enable-keepalive.patch
0003-Revert-reuse-strings-in-struct-request.patch
Description: 0003-Revert-reuse-strings-in-struct-request.patch
0004-free-ldap-attributes-direct-after-used.patch
Description: 0004-free-ldap-attributes-direct-after-used.patch
0005-add-missing-break-in-handle_response.patch
Description: 0005-add-missing-break-in-handle_response.patch
0006-better-error-messages.patch
Description: 0006-better-error-messages.patch
