On Thursday 09 January 2025 15:58:11 Jacek Caban wrote: > On 8.01.2025 21:40, Pali Rohár wrote: > > With the previous change, these 3 files can be compiled and included also > > for non-msvcrt-os import library. > > --- > > mingw-w64-crt/Makefile.am | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/mingw-w64-crt/Makefile.am b/mingw-w64-crt/Makefile.am > > index 97ab3b4742cc..7f8841a85f3f 100644 > > --- a/mingw-w64-crt/Makefile.am > > +++ b/mingw-w64-crt/Makefile.am > > @@ -772,6 +772,9 @@ src_pre_msvcr80=\ > > misc/__sys_errlist.c \ > > misc/__sys_nerr.c \ > > misc/_configthreadlocale.c \ > > + misc/_create_locale.c \ > > + misc/_free_locale.c \ > > + misc/_get_current_locale.c \ > > > What's the point of that? Those "emu" functions are useless, so a link > failure seems better than silently compiled broken code. A proper error also > gives build system a chance to adopt to the missing functionality. > > > Jacek >
The point is to provide those symbols also for other libraries. For msvcrt.dll builds we provide that dummy emu functions, so why not to have them also for other builds? For me it makes sense to provide these functions for all builds or none builds. Just for one build it looks strange. _______________________________________________ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
