On Wed, 8 Jan 2025, Pali Rohár wrote:
Function GetModuleHandle() returns HMODULE, not HANDLE. So function __mingw_get_msvcrt_handle() has to also return HMODULE. --- mingw-w64-crt/include/msvcrt.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Patches 1-3 seem definitely ok with me - we could push them without waiting for the rest of the discussion.
Patches 4-5 also looks good I think, and probably also can go in without waiting for patch 6.
As for patch 6, I have no extra feedback outside of what Jacek raised here.
// Martin _______________________________________________ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
