On Mon, 29 Jan 2024, Antonin Décimo wrote:
Signed-off-by: Antonin Décimo <anto...@tarides.com>
---
mingw-w64-libraries/winpthreads/tests/t_clock_getres.c | 2 +-
mingw-w64-libraries/winpthreads/tests/t_clock_gettime.c | 3 ++-
mingw-w64-libraries/winpthreads/tests/t_clock_nanosleep.c | 2 +-
mingw-w64-libraries/winpthreads/tests/t_clock_settime.c | 4 ++--
mingw-w64-libraries/winpthreads/tests/t_nanosleep.c | 3 ++-
5 files changed, 8 insertions(+), 6 deletions(-)
diff --git a/mingw-w64-libraries/winpthreads/tests/t_clock_getres.c
b/mingw-w64-libraries/winpthreads/tests/t_clock_getres.c
index f25be5aa3..4b111161f 100644
--- a/mingw-w64-libraries/winpthreads/tests/t_clock_getres.c
+++ b/mingw-w64-libraries/winpthreads/tests/t_clock_getres.c
@@ -45,7 +45,7 @@ static void test_clock_getres(char *name, int id)
printf("\n");
}
-int main(int argc, char *argv[])
+int main(void)
{
Why this change? I can understand removing unused local variables, which a
compiler might warn about, but unused function parameters generally should
be fine - especially argc/argv for main. I'm not really in favour of this
change as such.
diff --git a/mingw-w64-libraries/winpthreads/tests/t_clock_settime.c
b/mingw-w64-libraries/winpthreads/tests/t_clock_settime.c
index e3d18db2e..9a31c2780 100644
--- a/mingw-w64-libraries/winpthreads/tests/t_clock_settime.c
+++ b/mingw-w64-libraries/winpthreads/tests/t_clock_settime.c
@@ -9,7 +9,7 @@
static void test_clock_settime(void)
{
int rc;
- struct timespec tp, request = { 1, 0 }, remain;
+ struct timespec tp;
This is perhaps the only instance of a change that looks like what the
commit message says.
diff --git a/mingw-w64-libraries/winpthreads/tests/t_nanosleep.c
b/mingw-w64-libraries/winpthreads/tests/t_nanosleep.c
index 1d5897426..4400d1037 100644
--- a/mingw-w64-libraries/winpthreads/tests/t_nanosleep.c
+++ b/mingw-w64-libraries/winpthreads/tests/t_nanosleep.c
@@ -20,6 +20,7 @@ static unsigned __stdcall start_address(void *dummy)
{
int counter = 0;
struct timespec request = { 1, 0 }, remain;
+ (void)dummy;
This looks like a different issue/fix than the rest, please elaborate on
it, and/or split it to a separate commit for a different class of changes.
// Martin
_______________________________________________
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
