On 06/27/13 20:48, Rafaël Carré wrote: > Le 27/06/2013 18:33, Kai Tietz a écrit : >> 2013/6/27 Jacek Caban <ja...@codeweavers.com>: >>> On 06/27/13 18:11, Rafaël Carré wrote: >>>> Le 27/06/2013 17:17, Earnie Boyd a écrit : >>>>> On Thu, Jun 27, 2013 at 10:21 AM, Rafaël Carré wrote: >>>>>> However ___lc_codepage_func seems to be also present in msvcrt.dll so >>>>>> why do we need emul? >>>>> That depends on the version of MSVCRT.DLL on the users system. It is >>>>> emulated to avoid conflicts at runtime. >>>> That's what I am saying: it is always present. >>> It seems like it was introduced for win2k: >>> http://sourceforge.net/mailarchive/forum.php?thread_name=AANLkTin3%3DFSgfsahb5vd78gM_y47KEtijfSBdCeDWBB7%40mail.gmail.com&forum_name=mingw-w64-public >>> >>> Time to drop its support? >>> >>> Jacek >> Hmm, well, I know we still have some people at least expecting support >> for "special craftet" applications. Does this emulation-code really >> causes any major penalities for us? >> My 5 cents would go for keeping support here for w2k, so that at least >> startup (and some internal code) works still without issues for it. >> We should add a comment to it, which explict states that this code is >> w2k only, and therefore might get deprecated in future. >> >> Kai > Here is a crashing sample with x64 target: > > int main(void) > { > unsigned int __cdecl ___lc_codepage_func(); > return ___lc_codepage_func(); > }
I just tested your test case with your patch (with removed ___lc_codepage_func from msvcrt-common.def.in) and I couldn't reproduce the problem. I used Wine, so it was easy to emulate different missing exports from msvcrt.dll. I tested all three variants of emulation. Could you please retest and send me a binary if it still fails? Jacek ------------------------------------------------------------------------------ This SF.net email is sponsored by Windows: Build for Windows Store. http://p.sf.net/sfu/windows-dev2dev _______________________________________________ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
