2012/7/20 Ozkan Sezer <seze...@gmail.com>: > On 7/20/12, Corinna Vinschen <vinsc...@redhat.com> wrote: >> On Jul 20 20:15, Corinna Vinschen wrote: >>> On Jul 20 19:45, Kai Tietz wrote: >>> > 2012/7/20 Corinna Vinschen <vinsc...@redhat.com>: >>> > > Hi, >>> > > >>> > > The error codes returned by getaddrinfo and getnameinfo are defined >>> > > as int values. The below patch fixes that for EAI_NODATA. Ok? >>> > > >>> > > >>> > > Thanks, >>> > > Corinna >>> > >>> > Hmm, I think we should keep these kind of values long for LLP64 and >>> > ILP targets. >>> >>> Sorry, but that doesn't make sense, IMHO. >>> >>> getaddrinfo returns int: >>> >>> http://msdn.microsoft.com/en-us/library/windows/desktop/ms738520%28v=vs.85%29.aspx >>> >>> getnameinfo returns int: >>> >>> http://msdn.microsoft.com/en-us/library/windows/desktop/ms738532%28v=vs.85%29.aspx >>> >>> gai_strerror takes an int as parameter: >>> >>> http://msdn.microsoft.com/en-us/library/windows/desktop/ms738514%28v=vs.85%29.aspx >> >> Oh, I forgot something else. All other EAI_xxx values are defined >> in terms of WSA error values. The WSA error values are defined as >> int values anyway, see psdk_inc/_wsa_errnos.h. So EAI_NODATA is the >> only one defined as long value right now. >> >> >> Corinna >> > > Corinna's arguments make sense to me. I'm OK with whatever will > be the final decision. > > -- > O.S.
So, patch is ok. I just wanted to clarify this before ok-ing patch. Thanks, Kai ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
