On Thu, Apr 23, 2015 at 04:49:56PM -0700, Ben Widawsky wrote: > While trying to debug Skylake fast color clears, I noticed that the surface > state generated by our decoder was woefully inadequate. Much of the dumped > state > was so stale as to be useless. > > Just to be clear, the code is not auto generated from a spec, and so I'm > certain > there are bugs in the decoder. There are the typo kind of bugs, and then some > bugs where I feel the hardware spec is a bit vague, and I took a guess as to > how > things should work (I am looking at you Base mips). I guarantee that even with > whatever bugs present, the output with INTEL_DEBUG=batch is significantly > improved on all gen8+ platforms. Therefore, I think it makes a lot of sense to > not worry too much about any minor issues, and fix them up in later patches... > but it's your call. > > I made all of the character strings global since really any new code added to > the file would likely benefit from having it there. (Also potentially we get > slightly less bad performance when using INTEL_DEBUG=batch) > > I didn't intend to leave any major state changes out, so if you're aware of > one > I've missed, please don't hesitate to have me add it.
I guess we can add things little by little later on. Many thanks for doing this, such thing would have been helpful to me before. _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
