On 31/03/15 17:46, Brian Paul wrote:
On 03/31/2015 08:42 AM, Martin Peres wrote:
The issue has been detected by coverty.
v2:
- move the declaration of obj to the else clause (Brian Paul)
v3: Review by Brian Paul
- get rid of the obj declaration in favor of a direct reference
Signed-off-by: Martin Peres <[email protected]>
---
src/mesa/main/fbobject.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/src/mesa/main/fbobject.c b/src/mesa/main/fbobject.c
index 072e1a8..3808b56 100644
--- a/src/mesa/main/fbobject.c
+++ b/src/mesa/main/fbobject.c
@@ -1400,7 +1400,6 @@ create_render_buffers(struct gl_context *ctx,
GLsizei n, GLuint *renderbuffers,
bool dsa)
{
const char *func = dsa ? "glCreateRenderbuffers" :
"glGenRenderbuffers";
- struct gl_renderbuffer *obj;
GLuint first;
GLint i;
@@ -1419,13 +1418,11 @@ create_render_buffers(struct gl_context *ctx,
GLsizei n, GLuint *renderbuffers,
renderbuffers[i] = name;
if (dsa) {
- obj = allocate_renderbuffer(ctx, name, func);
+ allocate_renderbuffer(ctx, name, func);
} else {
- obj = &DummyRenderbuffer;
-
- /* insert the object into the hash table */
+ /* insert a dummy renderbuffer into the hash table */
mtx_lock(&ctx->Shared->Mutex);
- _mesa_HashInsert(ctx->Shared->RenderBuffers, name, obj);
+ _mesa_HashInsert(ctx->Shared->RenderBuffers, name,
&DummyRenderbuffer);
mtx_unlock(&ctx->Shared->Mutex);
}
}
Thanks, Martin.
Reviewed-by: Brian Paul <[email protected]>
I pushed the whole series, thanks for the review Brian!
_______________________________________________
mesa-dev mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
