Ian Romanick <i...@freedesktop.org> writes:
>[...]
>>>>
>>>> + if (field_type->atomic_size()) { + YYLTYPE
>>>> loc = decl_list->get_location(); +
>>>> _mesa_glsl_error(&loc, state, "atomic counter in structure or
>>>> " + "uniform block"); + }
>>>> +
>>>>
>>>> Are you sure this is not allowed? I can't find any spec text
>>>> to back this up. All I found was this text from
>>>> ARB_shader_atomic_counters:
>>>
>>> Yeah, this is definitely wrong. See the text I quoted in reply
>>> to patch 8.[...]
>>>
>> Please read my answer to Paul's post. It's not clear how atomic
>> counters declared within a structure would get their binding points
>> and offsets assigned: binding and offset qualifiers are disallowed
>> within structs, and using a single layout() qualifier for the whole
>> uniform struct declaration isn't satisfactory either. I think we
>> should disallow them for now, the spec is just too inconsistent...
>
> Yes... I see the problem now. I've submitted a spec bug. Until that
> bug gets resolved, let's continue with the assumption that atomic_uint
> should not be allowed in structs.
>
Thank you for doing that, do you have a link to the report?>> Thanks. >
pgpdmeEdoUpW7.pgp
Description: PGP signature
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
