Kenneth Graunke <kenn...@whitecape.org> writes: > On 10/12/2012 03:30 PM, Eric Anholt wrote: >> This code is twisty, and the comment before most of the blocks was actually >> giving me the opposite impression from its intention: We want to apply as >> much >> of our offset as possible through coarse tile-aligned adjustment, since we >> can >> do so independently per buffer, and apply the minimum we can through >> fine-grained drawing offset x/y, since it has to agree between all buffers. >> --- >> src/mesa/drivers/dri/i965/brw_blorp.h | 4 - >> src/mesa/drivers/dri/i965/brw_context.h | 8 ++ >> src/mesa/drivers/dri/i965/brw_misc_state.c | 111 >> +++++++++++++++++---------- >> src/mesa/drivers/dri/i965/gen6_blorp.cpp | 28 +------ >> src/mesa/drivers/dri/i965/gen7_blorp.cpp | 5 +- >> src/mesa/drivers/dri/i965/gen7_misc_state.c | 41 ++-------- >> 6 files changed, 89 insertions(+), 108 deletions(-) > > Thank you for doing this. I had a similar patch to refactor this, but I > had done a lot more refactoring and ended up breaking everything > something awful. > > Nice to have these tests fixed. > > For the series: > Reviewed-by: Kenneth Graunke <kenn...@whitecape.org>
Yeah, I tried a different refactor as well after the last patch, pushing more of this logic into shared cross-gen code, but it ended up bloating things up more. It's a horrible mess, but I'm not sure we can make it much better.
pgptoJZv1AFms.pgp
Description: PGP signature
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
