On 05/06/2018 05:31 PM, Timothy Arceri wrote: > On 05/05/18 07:28, Kenneth Graunke wrote: > >> On Thursday, April 26, 2018 2:28:41 PM PDT Ian Romanick wrote: >>> From: Ian Romanick <[email protected]> >>> >>> This code was clearly never tested. It's a good thing that no driver >>> ever tried to enable this path. >>> >>> Signed-off-by: Ian Romanick <[email protected]> >>> --- >>> src/mesa/main/ffvertex_prog.c | 10 ++++++---- >>> 1 file changed, 6 insertions(+), 4 deletions(-) >> That's not quite accurate. Gallium drivers advertise NV_fog_distance, >> but st_program calls _mesa_remove_output_reads(), which presumably >> lowers those away. It looks like none of the classic drivers are >> calling that, though, so they would be broken if they tried to enable >> this. Either your patch, or calling _mesa_remove_output_reads(), >> would probably solve the issue. >> >> At any rate, using a temporary seems reasonable. > > Since this patch landed. Do you guys think we can now remove > > _mesa_remove_output_reads() entirely?
Was this bit of ffvertex the only reason that function existed? Is it still needed for ARB assembly vertex programs? > _______________________________________________ > mesa-dev mailing list > [email protected] > https://lists.freedesktop.org/mailman/listinfo/mesa-dev _______________________________________________ mesa-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/mesa-dev
