On Thursday, April 26, 2018 2:28:41 PM PDT Ian Romanick wrote: > From: Ian Romanick <[email protected]> > > This code was clearly never tested. It's a good thing that no driver > ever tried to enable this path. > > Signed-off-by: Ian Romanick <[email protected]> > --- > src/mesa/main/ffvertex_prog.c | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-)
That's not quite accurate. Gallium drivers advertise NV_fog_distance, but st_program calls _mesa_remove_output_reads(), which presumably lowers those away. It looks like none of the classic drivers are calling that, though, so they would be broken if they tried to enable this. Either your patch, or calling _mesa_remove_output_reads(), would probably solve the issue. At any rate, using a temporary seems reasonable. Series is: Reviewed-by: Kenneth Graunke <[email protected]>
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ mesa-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/mesa-dev
