On Thu, Oct 19, 2017 at 12:45 PM, Ilia Mirkin <[email protected]> wrote: > On Thu, Oct 19, 2017 at 12:40 PM, Iago Toral <[email protected]> wrote: >> On Thu, 2017-10-19 at 12:37 -0400, Ilia Mirkin wrote: >>> Will this work with SSO shaders? Presumably the validation still has >>> to happen, but I don't think cross_validate_outputs_to_inputs() will >>> end up getting called. >> >> The piglit tests I mention use SSO so it seems to be working for this. >> See for example: >> >> tests/spec/arb_enhanced_layouts/linker/block-member-locations/named- >> block-member-location-overlap.shader_test > > Ah great. I'm a little curious how, since I don't see how > cross_validate_outputs_to_inputs would get called for SSO shaders. > Perhaps I'm looking at old code. > > Oh - because that test doesn't test SSO. It's missing a "SSO ENABLED" > - can you try with that? It's just using a pipeline, but both shaders > are ending up in it.
BTW, my solution to all this was https://patchwork.freedesktop.org/patch/175959/ but Tim hated it, and I didn't have the time to properly respond. -ilia _______________________________________________ mesa-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/mesa-dev
