On 6 October 2016 at 19:18, Axel Davy <[email protected]> wrote: > On 06/10/2016 11:34, Emil Velikov wrote: >> >> On 5 October 2016 at 21:08, Axel Davy <[email protected]> wrote: >>> >>> Uses the new defines introduced in previous commit. >>> >> Please describe why the newly introduced flags are used over the >> present ones. Worth copying some of the in-source comment or >> referencing it ? >> >> -Emil >> > Do you mean write for example: > > "Uses the new defines introduced in previous commit. > See comment in the commit for more explanation." > Virtually anything that does not require you to know exactly _what_ the patch does and _why_, prior to reviewing it. Then again, sometimes people get defensive on the brevity of their commit messages so... whatever floats your boat really.
Emil _______________________________________________ mesa-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/mesa-dev
