-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
I've investigated this a bit.
In 0.4 MartEditor, on Update all drop-down options in FilterDescriptions
are deleted and repopulated from the database. At the same time, the
filter type, qualifier, and legal qualifiers are reset. This occurs in
the getValidatedFilterDescription() method of
org.ensembl.mart.editor.DatabaseDatasetConfigUtils.
This behaviour persists right up to the present day.
I'm not sure in what way it needs to be fixed - the Update method is,
after all, supposed to synchronise the config with the actual contents
of the database, and so it necessarily has to modify the contents of the
options to match what is in the database. It is seeing values with %s in
which are not present in the database, and erasing them to be replaced
with the actual database values. Fair enough I would have thought?
Whether it should also correct any potentially broken filters by
overwriting the qualifier each time ('=' instead of 'like') is the main
question here I think.
Arek - what do you think? I don't see any harm in changing it to keep
existing qualifiers. In which case I can supply Andrew with brief
instructions as to how to modify his 0.4 code, and make the equivalent
change myself on the current head code.
Lastly, we should look at modifying our Perl code so that it can cope
with filter values which contain commas. Some kind of escape syntax may
be necessary.
cheers,
Richard
Arek Kasprzyk wrote:
>
> On 19 Jul 2007, at 14:39, Vallejos, Andrew wrote:
>
>> Yes...
>>
>> File->Update
>>
>> On the Mart Editor v0.4 changes 'LIKE' to '=' and erases all of the
>> '%'s from the value fields.
>>
>>
>
> Hi Andrew,
> sorry for the late reply, I was away.
> Let us look at the code, we'll get back with suggestions
>
> a.
>
> -------------------------------------------------------------------------------
>
> Arek Kasprzyk
> EMBL-European Bioinformatics Institute.
> Wellcome Trust Genome Campus, Hinxton,
> Cambridge CB10 1SD, UK.
> Tel: +44-(0)1223-494606
> Fax: +44-(0)1223-494468
> -------------------------------------------------------------------------------
>
>
>
>
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2.2 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iD8DBQFGp2KN4C5LeMEKA/QRAilzAJ0YcizVQFavaPGMsgBuW983Y9zLjwCgkt5f
Yj6k+sS0QBVKJpwDx6Q4ORA=
=2SeO
-----END PGP SIGNATURE-----
