[
https://issues.apache.org/jira/browse/MAPREDUCE-6706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18073043#comment-18073043
]
ASF GitHub Bot commented on MAPREDUCE-6706:
-------------------------------------------
pan3793 commented on code in PR #8422:
URL: https://github.com/apache/hadoop/pull/8422#discussion_r3070720885
##########
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapred/protocolPB/package-info.java:
##########
@@ -0,0 +1,29 @@
+/*
Review Comment:
~~why track these generated classes in the source tree? can't they be
generated on-the-fly?~~
##########
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapred/protocolPB/package-info.java:
##########
@@ -0,0 +1,29 @@
+/*
Review Comment:
noop, I misread it.
> Update TaskUmbilicalProtocol to use ProtobufRPCEngine
> -----------------------------------------------------
>
> Key: MAPREDUCE-6706
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-6706
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Reporter: Arun Suresh
> Assignee: Wei Zhou
> Priority: Major
> Labels: pull-request-available
>
> Currently, {{TaskUmbilicalProtocol}} still uses {{WritableRPCEngine}}, which
> should be moved to {{ProtocolRPCEngine}} so that the former can be deprecated
> as tracked by HADOOP-12579
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
