[
https://issues.apache.org/jira/browse/MAPREDUCE-6706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18073010#comment-18073010
]
ASF GitHub Bot commented on MAPREDUCE-6706:
-------------------------------------------
steveloughran opened a new pull request, #8422:
URL: https://github.com/apache/hadoop/pull/8422
Add .proto definition of the MR TaskUmbilicalProtocol and adopt it.
Because this is only used within an MR task, no need to worry about
compatibility...
the old protocol can be cut.
Implemented pretty much entirely with copilot and claude, with human review
of the results, extra comments.
Note that many of the complex datatypes (jvm_task, jvm_context, TaskStatus)
are actually
marshalled into bytes as a Writable and then converted at the far end.
What is different is there's no dynamic inclusion of class info in the
messages.
Also taking opportunity to look at old code and convert log statements with
string concat into {} templated logs, and some other IDE-hints/actions.
Contains content generated by Github Copilot.
### How was this patch tested?
Updated MR
### For code changes:
- [X] Does the title or this PR starts with the corresponding JIRA issue id
(e.g. 'HADOOP-17799. Your PR title ...')?
- [ ] Object storage: have the integration tests been executed and the
endpoint declared according to the connector-specific documentation?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`,
`NOTICE-binary` files?
### AI Tooling
If an AI tool was used:
- [X] The PR includes the phrase "Contains content generated by <tool>"
where <tool> is the name of the AI tool used.
- [X] My use of AI contributions follows the ASF legal policy
https://www.apache.org/legal/generative-tooling.html
> Update TaskUmbilicalProtocol to use ProtobufRPCEngine
> -----------------------------------------------------
>
> Key: MAPREDUCE-6706
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-6706
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Reporter: Arun Suresh
> Assignee: Wei Zhou
> Priority: Major
>
> Currently, {{TaskUmbilicalProtocol}} still uses {{WritableRPCEngine}}, which
> should be moved to {{ProtocolRPCEngine}} so that the former can be deprecated
> as tracked by HADOOP-12579
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
