================
@@ -106,3 +135,12 @@ Error 
AMDGPUCodeGenPassBuilder::addInstSelector(AddMachinePass &addPass) const {
   addPass(SILowerI1CopiesPass());
   return Error::success();
 }
+
+bool AMDGPUCodeGenPassBuilder::isPassEnabled(const cl::opt<bool> &Opt,
----------------
aeubanks wrote:

I'd prefer if we avoided adding this method, since it makes it too easy 
code-wise to keep around these flags. This might require cleaning up some flags 
so that we don't have to inline this method in so many places. IMO adding code 
noise around these flags is a good thing since these flags are undesirable.

https://github.com/llvm/llvm-project/pull/102867
_______________________________________________
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

Reply via email to