================
@@ -106,3 +135,12 @@ Error 
AMDGPUCodeGenPassBuilder::addInstSelector(AddMachinePass &addPass) const {
   addPass(SILowerI1CopiesPass());
   return Error::success();
 }
+
+bool AMDGPUCodeGenPassBuilder::isPassEnabled(const cl::opt<bool> &Opt,
----------------
aeubanks wrote:

is this pattern specific to AMDGPU? perhaps it should go in a more general place

also in general, is it necessary to have so many flags that force 
enable/disable passes? e.g. the middle-end optimizer doesn't have so many flags 
that force enable/disable passes

https://github.com/llvm/llvm-project/pull/102867
_______________________________________________
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

Reply via email to