asl wrote:

So, regarding big-endian things. Original siphash is always "little-endian" 
regardless of the host platform. On big endian hosts it essentially does byte 
swap in the end. We do not have it here, so we will end with different hashes 
on platforms with different endianness.

>From the pauth perspective this is not a problem, as we do not do 
>cross-platform hash calculation and further comparison. The hash output 
>(discriminator value) is always compiled on compiler side and left as-is.

So, we can either keep the present code as-is. Or we can just sprinkle few 
calls from `Endian.h` to do byteswap on BE platforms.

https://github.com/llvm/llvm-project/pull/94394
_______________________________________________
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

Reply via email to