ahmedbougacha wrote: > Do I understand correctly that "remove big-endian support" results in this > code not running correctly on big-endian machines? I don't recall the LLVM > project claiming that it cannot run on big-endian machines. If I understand > this correctly, I would not remove the big-endian support. (I think it also > helps with keeping the source code closer to the upstream siphash version, > which might have some benefits?)
That's a good call; we haven't tried to run it on BE hardware (I don't think we could have), but if it's supported I imagine this would have showed up on buildbots anyway. The way this version returns the result directly makes it interesting; I'm only assuming this would break, I haven't fully thought it through. Maybe we should stick to filling out the original buffer and let it all get optimized away. I'll take a look https://github.com/llvm/llvm-project/pull/94394 _______________________________________________ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
